Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Rbutil
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Tomer Shalev - 2009-10-31
Last edited by Tomer Shalev - 2009-10-31

FS#10748 - rbutil: Explicitly override GUI layout direction setting for some widgets

This patch overrides layout direction settings of about and System Trace text browser widgets to Qt::LeftToRight.

This is done since both these browsers display latin text, and it doesn’t look good when it is aligned to the right, as is the case if the utility language is set to Hebrew.

Closed by  Tomer Shalev
2009-10-31 17:16
Reason for closing:  Accepted
Additional comments about closing:  

Committed in r23441

Dominik Wenger commented on 2009-10-31 14:45

I think this patch is fine. And should just go in :-)

Dominik Riebeling commented on 2009-10-31 14:56

According to the Qt documentation Qt should be able to figure the layout direction by itself. This leads me to the assumption that forcing the layout direction (in main.cpp) itself is a bad idea though I haven't figured why it doesn't work automatically. IMO we should figure what's going wrong here instead of adding special cases (of course, if it's completely broken in Qt it's ok but not-really-nice to add workarounds. However, we should understand why it doesn't behave as advertised).

As a quick workaround this patch obviously doesn't do any harm so isn't problematic.

Dominik Wenger commented on 2009-10-31 15:10

The Qt Documentation isnt clear about this. For QApplication it says the LayoutDirection defaults to the language direction, and for QWidgets it says it defaults to LTR, so what is correct ?

So i think we have todo this Layoutdirection thing your self. (You can also see many Qt apps on the web which does this).

Tomer Shalev commented on 2009-10-31 16:49

Force several more widgets into left-to-right layout

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing