Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by tomers - 2009-11-14
Last edited by tomers - 2009-11-15

FS#10783 - WPS translation

Following WPS translation support in r22837, I’ve changed the wps files to get common WPS phrases using the %Sx skin tag.

This patch also contains the changes done in “ FS#10782  - WPS: Rename ‘Next Song’ to ‘Next Track’”

   wps_translate.diff (27.1 KiB)
Closed by  tomers
2009-11-15 21:40
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed in r23638.

tomers commented on 2009-11-14 20:02

This patch adds the followings:
- New conditional skin token 'Sr' which checks whether the currently loaded language is an RTL language (Hebrew/Arabic). It uses lang_is_rtl().
- The 'Sr' token is used across skin files to determine the location of colon, and the appropriate order of current track counter ('X of Y', or 'Y' of 'X').
- Added Hebrew translation

   wps_translation_including_rtl... (32 KiB)
tomers commented on 2009-11-14 20:19

Synced to r23626

   wps_translation_including_rtl... (32 KiB)
jdgordon commented on 2009-11-15 01:40

looks good, but the 2nd hunk in skin_parser.c needs to be removed… that is only for features which are not compiled into that build… rtl is something which could change while the skin is loaded which would mean the skin wont work after a lang change,

tomers commented on 2009-11-15 20:51

Changes from previous patch:
- Fix jdgordon's remark
- Use colon in the translated string itself, in order to save usage of %Sr in many places

   wps_translation_including_rtl... (30.9 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing