• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Domonoky - 2009-11-18
Last edited by Domonoky - 2009-12-02

FS#10794 - .[r]sbs support for the theme site

This is a patch to add .[r]sbs file checking into the theme site.

Unfortnuatly i couldnt test this at moment. Maybe someone else can test this ?

Closed by  Domonoky
2009-12-02 20:29
Reason for closing:  Accepted

fix sps → sbs typos.

This looks OK, does it also run it through checkwps? (not sure if that one can check sbs'es (yet))

the 3rd hunk looks wrong to me

I think checkwps can't check sbs yet, because it has hardcoded the extensions (wps, rwps).

Fix the error Kugel spottet.

And yes, this runs the sbs/rsbs files through checkwps. According to JdGordon checkwps should be able to cope with sbs file.

This still needs testing on some webserver to make sure it actually works :-)

just qualidfy that 2nd sentance…. There is no difference (that i can immediatly think of) between .sbs and .wps apart from its extension… so it would surprise me if checkwps couldnt handle it…

I also meant to mean that the hardcoded extensions is the only thing that needs to be fixed to make it parse sbs files :)

You seem to add the filename to $rspsfound, but then check $rsbsfound.

ups. Fix typo

Finally i was able to test this. And it works ! :-)


Available keyboard shortcuts


Task Details

Task Editing