FS#10804 - Add touchscreen mode indication to status bar
Opened by Rob Purchase (shotofadds) - Sunday, 22 November 2009, 20:23 GMT
|
DetailsThe attached patch adds an indication of the current touchscreen mode to the "classic_statusbar" skin. This is useful since some screens automatically change mode, and there's currently no indication the user when this happens. The patch does the following:
- Adds a new WPS tag (%Tm) to return the current touch mode (Absolute|Grid) - Updates classic_statusbar.sbs to conditionally show the correct icon The reason I've made this a Flyspray task rather than just committing it is because the additions to classic_statusbar.sbs will also apply to non-touchscreen targets (though nothing will appear on screen). While the impact on these targets is minimal, I'm not sure about committing it since it will at least cause the new touchmode.bmp to be loaded unneccesarily. Also, feel free to design some better icons! |
I like the idea, but a problem with plugins is that they don't (always) display the statusbar, so you can't see in what touchscreen mode you are..
Also, if you don't want to load touchmode.bmp I suppose you could split the classic statusbar into a normal and a touchscreen sbs? (btw, isn't there a fixed-size buffer atm for SBS/WPS data? If so, loading an extra bmp probably won't increase RAM size)
@mcuelenaere, yes you're right - the fixed sized buffer means there's no extra overhead. As for a touch variant, I'd rather avoid that especially for a simple variation like this.
shotofadds, have a look at how RTC support is handled (check_feature_tag() in skin_parser.c)
I added a %Tp ("touchscreen present") tag, which works for certain things eg. %?Tp<%?Tm<%xdTa|%xdTb|>>
but if I try to protect the %xl or %V lines with this conditional it results in "ERR: Unclosed conditional" when loading the .sbs.
I think it's worth having this tag, but only if it can be used in all places....
%Tp<%Xl|.....|
|other stuff>
I also want to get the new icon into the inbuilt bar because that isnt likely to be removed any time soon after all...