FS#10856 : Skip to previous track inconsistent when using cuesheet

Status Closed
Percent Complete
100%
Task Type Patches
Category User Interface
Assigned To

mc2739
Operating System All players
Severity Low
Priority Very Low
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by mc2739 - 2009-12-15
Last edited by mc2739 - 2010-01-06

FS#10856 - Skip to previous track inconsistent when using cuesheet

Skipping to the previous track without cuesheet support enabled works as follows:
If track elapsed time is less than 3 seconds, skip to previous track
If track elapsed time is 3 seconds or more, skip to the start of current track

Skipping to the previous track with cuesheet support enabled currently works as follows:
If first segment elapsed time is less than 3 seconds, skip to previous track
If first segment elapsed time is 3 seconds or more, skip to the start of first segment
In any other segment after the first, skip to the start of the previous segment

This patch makes skip previous consistent on a track with cuesheet support. If skip previous is pressed in any segment before 3 seconds have elapsed, skip to the previous segment (or previous track if in the first segment). If skip previous is pressed in any segment with 3 or more seconds elapsed, skip to the start of the current segment.

cuesheet-skip.patch (2.8 KiB)

Closed by mc2739
2010-01-06 14:56
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed in r24191