Rockbox

  • Status Unconfirmed   Reopened
  • Percent Complete
    0%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Mike Schmitt - 2010-01-09
Last edited by Bertrik Sikken - 2010-01-12

FS#10905 - Song-Specific AlbumArt should also look for Songname in metadata

There should be another option on the list of prioritized options for where to place Album Art images and the filenames. There are currently 7:
http://www.rockbox.org/wiki/AlbumArt

My suggested addition would become the new option 2, pushing all others down.
The first option is currently the only option to allow for song-specific artwork to be displayed, but this requires naming the image files *exactly* like the corresponding sound file, which screws up directory sorting.

Therefore the option should be added that if no image file has an identical name to the sound file playing, it then looks for an image file which matches the current song's Title metadata, similarly to how the following option looks for a match to the Album metadata.

This could cause conflicts when two songs have the same name, or when a song shares the album's name, or the song name contains unusable characters, but such conflicts are rare and minimal, and if anyone cares all that much about such things there is already the built-in flexibility to get around such issues. The additional code required should be minimal (and already blueprinted within the other options), and have essentially zero impact on any other functionality.

I may try to write this patch myself (as i did with "shuffle + track skip"), but if anyone beats me to it, it would be appreciated :)

Mike Schmitt commented on 2010-01-12 18:34

I have the patch ready. It's tested working in the simulator.

Mike Schmitt commented on 2010-01-13 05:59

Here is another version of the patch with most of my test comments pared out. the only comment left in is the one explaining the changed functionality.

Michael Chicoine commented on 2010-01-13 15:02

Rockbox has a real name policy. For your patch to be considered, you will have to supply your real name. You can edit your profile by clicking on your userid in the top left corner.

You might also want to check the file docs/CONTRIBUTING in your SVN checkout, or here: http://svn.rockbox.org/viewvc.cgi/trunk/docs/CONTRIBUTING?view=markup
This gives information about Rockbox source code conventions. In reference to your patch, please note the part in the "Style" section concerning TAB characters.

Mike Schmitt commented on 2010-01-14 07:34

Gotcha; wasn't aware of the Real Name policy (nobody mentioned it when I did my first patch, which was over 3 years ago iirc; they just asked me my real name to add to the credits). And understood about Tabs; my editor did the tabbing for me but I can manually redo the ones found in my patch.
Here is the fixed version. Please let me know if you have further comments.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing