Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Recording
  • Assigned To No-one
  • Operating System Sansa e200
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by lee321987 - 2010-01-17
Last edited by nls - 2010-01-18

FS#10917 - MP3 encoder is not working

(build: e200v1 - r24254)

Recording into MP3 format results in a file with no sound (actually has a very strange noise _pattern_, but you have to amplifiy alot to hear it).

Example MP3:

Closed by  nls
2010-01-18 07:47
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

fixed in r24271

tested with r24262 on e280v1

1) MP3 recording works fine on my e200 both from the mic and fm radio.

2) This sounds like a duplicate of  FS#10678 

nls commented on 2010-01-17 21:56

Please note that the mp3 encoder plugin and the mp3 encoding codec are two entirely seperate peices of code.
AFAIU this is using the encoding codec while recording and fs#10678 is with the plugin.

William, could you please provide your recording settings and try if it works with older versions of rockbox and if other recording formats are affeted?

Michael Chicoines’ comment made sense with my original post, but I had an admin edit my original post because it mentioned the same bug that MC linked to.

Other formats record correctly.

My settings:
bitrate: 32kbps
source: mic and FM – neither works
channels: mono
mono mode: mono Left + Right

I was bisecting old versions, but seem to have installed a version that needs an older bootloader, so now my player won’t boot, and I have to go back through how to fix this,

Through bisecting I found out the commit that caused this:
http://svn.rockbox.org/viewvc.cgi?view=rev;revision=23784

Mono Modes:
Mono Left + Right —— does not work
Mono Left —————- WORKS
Mon Right —————- does not work

nls commented on 2010-01-18 03:03

I committed a fix to l+r, it was only using one channel, however it seems one channel is lost too, so this looks like another bug, you do get sound in both channels when recording in stereo?

edit: committed another fix that might fix the other problem

edit: comitted a fix that i am fairly confident should work now

Stereo ======= good
Mono L+R ==== strange distortion
Mono R ====== strange distortion (louder)
Mono L ====== good

All modes play back in both ears.

Looks good. Thank you Nils.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing