Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Release 3.5
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by jdgordon - 2010-01-20
Last edited by jdgordon - 2010-01-29

FS#10922 - SBS cleanup, remove lots of bandaids.

This patch changes *internally* how the colour, backdrop and ui viewport setting are used.

if a .sbs fails to load (or is never loaded) a in ram sbs is created from the above settings and loaded.

This first version doesnt hande backgrounds at all, everything else should work the same as svn

Closed by  jdgordon
2010-01-29 07:52
Reason for closing:  Accepted
Additional comments about closing:  

in 24366.

new version… so many fixes. moves backdrops into the skin buffer. Makes the whole system follow the “only use the setting as a fallback” motto, except load/clear backdrop which needs a think about.

change how skins and the backdrop setting work to make them the same as svn.
%Xd will not dispaly any backdrop, %X|filename.bmp| will use that file, no %X tag will use the backdrop setting *NOT* the one loaded in the sbs (this might change if both are using the setting)

also change the buffer size to have room for 2 full colour screens and 1 backdrop for each screen (svn is 1 full colour screen, 2 full mono screens, and 1 backdrop per screen) ~180KB extra on e200. this should be able to come down if the above bracketed text happens… also this should eventually be user configurable.

load/clear a backdrop from the file browser/menu will unconditioanlly change the sbs backdrop. you might need to change the .sbs file to have it change permanenelty (which makes sense.)

sync to svn

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing