FS#10935 - Fractals only showing a full black screen with greylib

Attached to Project: Rockbox
Opened by Marianne Arnold (pixelma) - Friday, 29 January 2010, 00:39 GMT
Last edited by Rafaël Carré (funman) - Saturday, 30 January 2010, 07:16 GMT
Task Type Bugs
Category Plugins
Status Closed
Assigned To Tomer Shalev (tomers)
Operating System Archos Ondio
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


As the title says, the plugin is currently only drawing a black screen on targets where greylib is used - right from entering the plugin and zooming or moving around changes nothing. This is with revision 24365 but I saw it in slightly older builds too.

I experience this on my OndioFM (monochrome), Iaudio M5 (greyscale) and in an Ipod Mini sim, so it's fairly safe to assume that it happens on all greylib targets. On my M5 the previous build was new enough that the older mandelbrot.rock still work and it does not have this problem.

Fractals works on my c200 which has a colour screen but I have to admit that I don't like the new colours much because it's now a much smaller colour "range". Of course, that's not the bug but maybe it has to do with it?
This task depends upon

Closed by  Rafaël Carré (funman)
Saturday, 30 January 2010, 07:16 GMT
Reason for closing:  Fixed
Additional comments about closing:  r24377
Comment by Bertrik Sikken (bertrik) - Friday, 29 January 2010, 09:54 GMT
I can confirm this for the Sansa Clip too, it also uses greylib for the fractals plugin.
Comment by Dominik Riebeling (bluebrother) - Friday, 29 January 2010, 18:46 GMT
Confirmed on H100 (r24364), m:robe 100 (r24370) and Mini2G (r24255). Mini2G shows a white screen, all others a black one.
Comment by Rafaël Carré (funman) - Saturday, 30 January 2010, 06:24 GMT
r24309 didn't had the intended effect:
Fractals: this should fix bugs on simulator for greyscale LCD targets.
* moved #define USEGSLIB to fractal_sets.h and include only needed header file.
* include plugin.h so that LCD_DEPTH is defined.
* explicitly include fractal_sets.h in mandelbrot_set.c

Comment by Rafaël Carré (funman) - Saturday, 30 January 2010, 07:04 GMT
bug wasn't in the sim but in the colors calculation = all colors were 0
Comment by Rafaël Carré (funman) - Saturday, 30 January 2010, 07:11 GMT
And yes color range is weirdly done, I don't quite get what max_iter really is.