Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface → Language
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by salaba - 2010-02-06
Last edited by jdgordon - 2010-05-20

FS#10976 - String <untagged> isn't in language files

I found that string <untagged> using in tag browser / tag cache
isn’t in language files.

Here is my example which could be added to english.lang, but it is still necessary to make the necessary modifications to the source code to interpret it, to which I do not have any apprentice of an experienced.

<phrase> 

id: LANG_TAGNAVI_UNTAGGED
desc: "<untagged>" entry in tag browser
user: core
<source>
  *: "<untagged>"
</source>
<dest>
  *: "<untagged>"
</dest>
<voice>
  *: "untagged"
</voice>

</phrase>

Closed by  jdgordon
2010-05-20 13:25
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

in r26192.

Akur commented on 2010-02-09 16:33

This happens because the tag <untagged> is used when building the database.

salaba commented on 2010-02-09 21:48

I found string “<Untagged>” that is hard defined in file /apps/tagcache.c
on line 96 : 

  #define UNTAGGED "<Untagged>"

Other string for tag bwovser / tag cache are defined in file /apps/tagtree.c
on lines 1150 : 

  dptr->name = str(LANG_TAGNAVI_ALL_TRACKS);

and line 1157 : 

  dptr->name = str(LANG_TAGNAVI_RANDOM);

I think that would be sufficient to adjust in file /apps/tagcache.c
the line 96 like this : 

     #define UNTAGGED LANG_TAGNAVI_UNTAGGED

And add new id: LANG_TAGNAVI_UNTAGGED to file /apps/lang/english.lang
as I wrote example in base of this report.

jdgordon commented on 2010-02-09 21:52

no, doing that will break the database if you try moving it between targets or even when loading a different language.
The way to do it is to rename the entry in tagtree.c when the search results are loaded.

Akur commented on 2010-02-09 22:57

I was working on it and I have submitted a patch for it.

See please  FS#10992 .

salaba commented on 2010-02-09 23:34

Great work Akur.
We will waiting to cominting.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing