FS#11009 : Include dualboot.h in dualboot.c as an additional compiletime sanity check

Status Closed
Percent Complete
100%
Task Type Patches
Category Bootloader
Assigned To No-one
Operating System Another
Severity Low
Priority Very Low
Reported Version Rbutil git
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by ranma - 2010-02-13
Last edited by bertrik - 2010-02-13

FS#11009 - Include dualboot.h in dualboot.c as an additional compiletime sanity check

This small patch prevents you from bricking your player if you forget to update dualboot.h in addition to dualboot.c.
Without the patch a mismatch dualboot.c/dualboot.h combination compiles, but of course the patcher then copies the wrong size.
With the patch you get a compiler error due to type mismatch:

CC dualboot.c
dualboot.c:63: error: conflicting types for ‘dualboot_c200v2’
dualboot.h:6: error: previous declaration of ‘dualboot_c200v2’ was here
make: *** [build/dualboot.o] Error 1

http://forums.rockbox.org/index.php?topic=14064.msg162128#msg162128

Closed by bertrik
2010-02-13 19:02
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed as SVN r24636, thanks.