Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System All players
  • Severity High
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by tomers - 2010-02-17
Last edited by jdgordon - 2010-02-18

FS#11033 - Rockbox crash when displaying ID3 info with crazy long comment field

Rockbox crashes when going to the ID3 screen while playing the attached mp3 file.
This is reproducible in both target and simulator (r24725).

(gdb) r
Starting program: /home/user/rockbox/build_cowond2_s/rockboxui
… Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xb75e9b70 (LWP 19429)]
0x080be46b in font_cache_insertion_point (fcache=0x82490fc, char_code=65527)

  at /home/user/rockbox/firmware/font_cache.c:113                   

113 p = lru_data(&fcache→_lru, index[0]);

Closed by  jdgordon
2010-02-18 05:44
Reason for closing:  Fixed
Additional comments about closing:  

see last comment

I will personally send the affected mp3 file to whomever is interested (contact me)

this is a buffer overrun for sure. the comment field is 1126 chars, and the id3 buffer is… #define ID3V2_BUF_SIZE 900 so its hardly surprising that it crashes.
I cant see how the mp3 metadata parser works, but this *isnt* a font bug.

nope, I take that back. the mp3entry isnt breaking it. the scroll code breaks trying to show such a long line… still tracking down why its not handling it correctly.

band aided in r24743.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing