• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category User Interface
  • Assigned To
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by tomers - 2010-02-21
Last edited by jdgordon - 2010-03-14

FS#11046 - Quickscreen WPS icons

In this patch, WPS icons for Shuffle and Repeat are shown beneath the corresponding text labels.

The patch is a work in progress and is likely to fails on targets with smaller screens, such as the attached clip screenshot. There are way too many end cases in quickscreen_fix_viewports()… This patch was tested on the default Cabbie theme. It currently doesn’t handle well the case of really large icons, etc.

The patch still holds some limitation, such as support for icons only for Shuffle and Repeat (it could be made more generic), and only for the left and right Quickscreen items (not the top and bottom items).

I would like to get more comments and suggestions.
This patch could raise a discussion on whether we can use a wps file for the Quickscreen or not, etc…

Closed by  jdgordon
2010-03-14 12:18
Reason for closing:  Rejected

IMO this isn’t needed at all and I don’t see the point of it. I, for example, have removed the shuffle item from the quickscreen.

Showing icons in the quickscreen raises the demand for icons for all possible settings.

Why do you want this?

agreed. this should be rejected.
it looks better sure, but the quickscreen is customisable so this doesnt make sense really


Available keyboard shortcuts


Task Details

Task Editing