FS#11046 - Quickscreen WPS icons

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Sunday, 21 February 2010, 21:16 GMT
Last edited by Jonathan Gordon (jdgordon) - Sunday, 14 March 2010, 12:18 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To Tomer Shalev (tomers)
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


In this patch, WPS icons for Shuffle and Repeat are shown beneath the corresponding text labels.

The patch is a work in progress and is likely to fails on targets with smaller screens, such as the attached clip screenshot. There are way too many end cases in quickscreen_fix_viewports()... This patch was tested on the default Cabbie theme. It currently doesn't handle well the case of really large icons, etc.

The patch still holds some limitation, such as support for icons only for Shuffle and Repeat (it could be made more generic), and only for the left and right Quickscreen items (not the top and bottom items).

I would like to get more comments and suggestions.
This patch could raise a discussion on whether we can use a wps file for the Quickscreen or not, etc...
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 14 March 2010, 12:18 GMT
Reason for closing:  Rejected
Comment by Thomas Martitz (kugel.) - Monday, 22 February 2010, 10:47 GMT
IMO this isn't needed at all and I don't see the point of it. I, for example, have removed the shuffle item from the quickscreen.

Showing icons in the quickscreen raises the demand for icons for all possible settings.

Why do you want this?
Comment by Jonathan Gordon (jdgordon) - Monday, 22 February 2010, 17:51 GMT
agreed. this should be rejected.
it looks better sure, but the quickscreen is customisable so this doesnt make sense really