Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#11047 : Simplify keyboard code

Rockbox

Tasklist

FS#11047 - Simplify keyboard code

Attached to Project: Rockbox
Opened by Fred Bauer (freddyb) - Monday, 22 February 2010, 04:43 GMT
Last edited by Teruaki Kawashima (teru) - Thursday, 25 February 2010, 07:11 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch makes no functional changes but simplifies the code by putting each user action into a separate function making the code more maintainable and allowing reuse of code in the future.
   keyboard.c (34 KiB)
   simple_keyboard-v1.diff (21.4 KiB)
This task depends upon

Closed by  Teruaki Kawashima (teru)
Thursday, 25 February 2010, 07:11 GMT
Reason for closing:  Accepted
Additional comments about closing:  Commited partially with some changes.
Comment by Teruaki Kawashima (teru) - Monday, 22 February 2010, 08:10 GMT
i don't like this so much. i think it adds too many function. also it increase ram usage by ~280 bytes.
Comment by Fred Bauer (freddyb) - Monday, 22 February 2010, 17:04 GMT
Are you joking?

Loading...