Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Fred Bauer - 2010-02-22
Last edited by Teruaki Kawashima - 2010-02-25

FS#11047 - Simplify keyboard code

This patch makes no functional changes but simplifies the code by putting each user action into a separate function making the code more maintainable and allowing reuse of code in the future.

   keyboard.c (34 KiB)
   simple_keyboard-v1.diff (21.4 KiB)
Closed by  Teruaki Kawashima
2010-02-25 07:11
Reason for closing:  Accepted
Additional comments about closing:  

Commited partially with some changes.

Teruaki Kawashima commented on 2010-02-22 08:10

i don’t like this so much. i think it adds too many function. also it increase ram usage by ~280 bytes.

Fred Bauer commented on 2010-02-22 17:04

Are you joking?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing