Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Clément Pit--Claudel - 2010-02-24
Last edited by Rafaël Carré - 2010-02-25

FS#11056 - Alarm clock plugin

This patch adds an “alarmclock” plugin, which basically resumes playback at a given time. Think of it as a play timer, as opposed to the sleep timer.

I found it useful, provided that it is no problem for me to leave my player on overnight. Should work on most targets with an RTC (however the code has not been tested but on Gigabeat), and shouldn’t break compilation anyway.

Does the same as  FS#6044 , but that one seemed pretty old (I should maybe search FS before coding patches though).

This is a very simple plugin, that would better be merged into the core, for targets which are not able to automatically wake up. I do not have, however, the required talent (or knowledge of the code) to do this.

CFP.

PS: While developing this plugin, I noticed that for a few seconds after booting the sim, the clock dosen’t update.

(by the way, the reported version list in the tacker posting interface doesn’t show v3.5)

Closed by  Rafaël Carré
2010-02-25 14:45
Reason for closing:  Accepted
Additional comments about closing:  

r24912

Clément Pit--Claudel commented on 2010-02-24 18:09

Woops

Clément Pit--Claudel commented on 2010-02-24 18:10

Wrong exit status (and I can’t click the right button, it seems ; sorry).

Clément Pit--Claudel commented on 2010-02-24 19:27

Update the diff to add the rockbox header, and a manual section (which does need proofreading though).

One bug remains (as discussed on IRC): when starting the plugin, if no playlist control file has ever been created, an error message is displayed (error accessing playlist control file). Since the audio resume code was actually taken from the playback menu in plugin lib, this bug happens in every plugin: for example, try to start codebuster on a clean sim build, and resume the audio playback from the playback menu.

I believe this doesn’t need fixing, provided that the error message is very neat.

Clément Pit--Claudel commented on 2010-02-24 19:55

Update the patch as per funman’s comments.

Clément Pit--Claudel commented on 2010-02-24 20:00

After discussion on IRC, the “bug” is actually the desired behavior :)
CFP.

Clément Pit--Claudel commented on 2010-02-24 20:02

Tested on most sims, seems ok.
CFP.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing