Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Battery/Charging
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by MichaelGiacomelli - 2010-02-27
Last edited by MichaelGiacomelli - 2010-02-27

FS#11066 - Fix running time screen to work on targets with software USB

Currently on PP, AMS, and probably others the “Running Time” screen doesn’t actually get reset when rockbox is charged. The only way it’ll actually get reset that I can find is if the user inserts a charger while the running screen is open or the nvram is cleared.

This patch changes default_event_handler_ex to reset the running time on USB_DISCONNECT or CHARGER_DISCONNECT events.

Closed by  MichaelGiacomelli
2010-02-27 23:09
Reason for closing:  Accepted
Additional comments about closing:  

Accepted in r24954.

Admin
Frank Gevaerts commented on 2010-02-27 21:45

- Not all players charge over USB, so USB disconnect does not necessarily mean end of charging
- not all code necessarily uses default_event_handler_ex()
- The USB disconnect event actually means MSC disconnect. If you charge without MSC, (by holding the appropriate button while connecting), this won't trigger

In general, I think this is really the wrong place to handle this

MichaelGiacomelli commented on 2010-02-27 22:19

Updated patch following discussion here: http://www.rockbox.org/irc/log-20100227#22:34:27

The new patch moves MSC mode detection to usb_screen.c in order to hopefully miss fewer events.

MichaelGiacomelli commented on 2010-02-27 22:27

Remove needless statement.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing