• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by punkt - 2010-03-12
Last edited by jdgordon - 2010-06-15

FS#11096 - %Tl: Set the last touch time intially to 0

As it is now, last_touchscreen_touch is initialized to 0xffff, which is in the future. Therefore %Tl is true at rockbox start, and doesn’t turn to false after the timeout of %Tl elapsed. This seems wrong, since the user hasn’t actually touched yet.

With the proposed patch, %Tl is also true at rockbox start, but turns to false after the timeout elapses.

I thought of initializing last_touchscreen_touch to INT_MIN, but that didn’t work for some reason.

Closed by  jdgordon
2010-06-15 06:55
Reason for closing:  Accepted

does this fix the problem? I tried in the sim and got nowhere

punkt commented on 2010-03-27 14:06

That fix works for me in the sim.


Available keyboard shortcuts


Task Details

Task Editing