Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Codecs
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by learman - 2010-03-14
Last edited by Buschel - 2010-03-14

FS#11103 - MPC resume doesn't always work

Resuming a MPC track doesn’t always work; sometimes it start at 0:00. This seem to happens because the MPC codec use id3→offset field as a sample offset, while the Rockbox core use it as file offset. If the resume offset is bigger than the file size, it is reset to zero by the playback code. The mpc decoder library only has a private low-level function for seeking to a particular file offset, so it isn’t a trivial fix.

Closed by  Buschel
2010-03-14 13:33
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Fixed with r25164 (with additional change to keep precision of time position over save/resume).

Buschel commented on 2010-03-14 13:24

Good point! This failure happened since ages…

The following patch corrects the usage of rockbox’s “offset” when resuming playback and when saving the current position for persistency.

   mpc_resume_v02.patch (2 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing