Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Drivers
  • Assigned To
    Buschel
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Buschel - 2010-03-23
Last edited by Buschel - 2011-01-09

FS#11141 - Do not boost while buffering when DMA is used

This patch was extracted from  FS#9708 . It removes the boost/unboost for buffering when HAVE_ATA_DMA is defined. Reason to do so is: a) buffering speed does not depent on CPU boost when DMA is used, b) boosting shall only be used, if neccessary.

Closed by  Buschel
2011-01-09 19:05
Reason for closing:  Rejected
Additional comments about closing:  

Will not be submitted to svn and has some flaws (e.g. not taking into account whether the connected drive really uses DMA).

cpu98 commented on 2010-03-23 21:51

I forgot to report to  FS#9708 :
ata.v9.patch + buffer_cacheline_alignment_v3.patch combo(that I said unstable for mine long ago, currently in svn) worked fine.
Maybe that was other buffering problem then.
Bye.

cpu98 commented on 2010-03-23 21:53

correction:
ata.v9.’patch + buffer_cacheline_alignment_v3.patch’ to
v9 + buffer _cache_alignment_v2

torne commented on 2010-03-24 08:43

It’s not entirely clear what you mean; if you are still interested in testing this change, then test it on top of svn, which now includes all the DMA code.

cpu98 commented on 2010-03-24 16:44

I know current svn have them all and what I’m saying is not related to this patch.
Just wanted to report to him because I might have confused him before….
Thanks for worrying me.

cpu98 commented on 2010-03-24 16:48

OMG I terribly mistyped.
Thanks for worrying about me.

Sync’ed against r25340.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing