• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by amr - 2010-04-03
Last edited by tomers - 2010-04-07

FS#11169 - Unstable text viewer

The recent updates after revision 24897 to viewer.c (currently revision 25400) causes the following:

- Latin script files open normally, but on exit of viewer and returning to file menu, rockboxui terminates with a message: stack smashing detected

- When trying to open a file containing diacritics (Arabic), the file doesn’t open successfully and rockboxui terminates with the message:
Can’t open font: /.rockbox/fonts/6-GNU-Unifont.fnt
Floating point exception

Closed by  tomers
2010-04-07 18:08
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Should be fixed in r25516. Reopen if needed.

The recent updates after revision 24897 to viewer.c
r24897 has nothing to do with that. It's a keymap definition commit.

Can you please locate when these bugs were introduced with respect to the following commits?

Revision 25233-25235, by uchida: text viewer plugin applies patches  FS#8445 ,  FS#9546 ,  FS#9853 ,  FS#9855 ,  FS#9892 ,  FS#9893 ,  FS#9898 ,  FS#9902 , and  FS#9990 .

Revision 25262, by torne: Prevent accidental skipping to beginning/end of file in text viewer.

Revision 25400, by me: Viewer: Implement alignment option, to provide alignment of RTL text (Hebrew, Arabic) to the right

P.S. Amr, please upload the two files that causes the symptoms you describe (the one with arabic diacritics and that with the latin script)


amr commented on 2010-04-03 11:33

I've traced the updates revision by revision and here are my observations:
R 24897 is the last stable one that produces the expected results
R 25233 introduces unwanted new lines occasionally (the viewport could afford showing 2 words on one line in the former revision, here in some cases each word appears on a separate line)
R 25234 the same as the previous
R 25235 the same too
R 25262 the same too
R 25400 some files (attached README.txt, 1.txt) open normally but on viewer exit, rockboxui aborts with error:

> Skin buffer usage: 81228/317952                                                 
> *** stack smashing detected ***: ./rockboxui terminated                         
> ======= Backtrace: =========  

While rockboxui aborts on opening other files (attached 2.txt, كلام مُشَكَّلٌ.txt) with error:

> Skin buffer usage: 81228/317952
> Can't open font: /.rockbox/fonts/6-GNU-Unifont.fnt
> Floating point exception

- I updated svn to the latest revision and reverted my local changes in other files to isolate the problem
- I created a new simulator build and I simulate on target Sansa e200
- I've stated before that the first problem (stack smashing) relates to Latin characters and the second (floating point exception) relates to diacritics, but this isn't true as both problems happened with both types of scripts

Hopefully, all of the above mentioned issues have now been resolved. Please test r25516 (and up) and report your your findings.


Available keyboard shortcuts


Task Details

Task Editing