Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Music playback
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Blue_Dude - 2010-04-06
Last edited by Blue_Dude - 2010-04-10

FS#11178 - Bookmarks can store optional tokens w/o breaking backward compatibility - Add pitch and timestretch

Added capability to parse bookmarks that may contain optional tokens. Can also parse any version of bookmark so that backward compatibility is always maintained (mix and match at will).

As a demo (and to add as a permanent feature), this patch adds pitch and timestretch tokens to bookmarks and applies their settings when played back.

   bmark.patch (3.7 KiB)
Closed by  Blue_Dude
2010-04-10 21:18
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed in r25576

Blue_Dude commented on 2010-04-07 02:54

Synced to r25504. Retains new pitchscreen tokens, but eliminates deprecated token in old bookmark format.

   bmark2.patch (3.8 KiB)
Blue_Dude commented on 2010-04-08 01:31

Removes all flags except for optional tokens. Cleaner code.

   bmark3.patch (5.9 KiB)
fml2 commented on 2010-04-08 19:10

I have not tried out the patch (can’t comple right now) but I don’t like the cryptic names F_PIT_RAT and F_TIM_STR. We’re not developing a CPU here! :-)

Blue_Dude commented on 2010-04-08 19:23

The flag names are a holdover from a much larger list. I’ll make them more human friendly.

Blue_Dude commented on 2010-04-08 21:29

Friendlier tags. Pitch and speed are preset to 100% (not current values) when playing a bookmark and the bookmark doesn’t have pitch and speed values.

   bmark4.patch (5.9 KiB)
fml2 commented on 2010-04-09 07:45

Why do I always read “TIMESTR” as “time string”? ;-)

Blue_Dude commented on 2010-04-10 00:19

Code cleanup. “TIMESTR” is now “SPEED” ;-) Some variables renamed for clarity. Changed default behavior for legacy bookmarks back to *not* changing speed and pitch since that info is not specifically present. Changed the new bookmark format a bit: the id header string “bmark;” wasn’t really needed; any non-digit would do. Now there’s just a header character “>” to identify the new format.

   bmark5.patch (6.2 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing