• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Uchida - 2010-04-19
Last edited by Uchida - 2010-06-05

FS#11209 - rework the text viewer plugin.

I previously had committed wrong the new text viewer plugin, which was completed.
This not only split the file and reviews all logics, I have created many new functions,
I think that there are problems that viewer.rock does not occur.
Please check various players, text file and settings.

(1) Though I create the new text viewer the same behavior of the viewer.rock,
some features are differently. (see “Difference between viewer.rock” in readme.txt)

(2) If you apply this patch, the viewer.rock is created and if you viewer.config change,
viewer.rock can be used.

(3) In IRC, though I received the advice that I should remove “tv_” prefix from all file names,
I did not change all file names because there exist already the sames or similar names.

(4) I accept the feature request. But I do not add the new feature other than bug fixes
until this task is closed. (I add only TODO list)

Closed by  Uchida
2010-06-05 11:55
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

the current patch commits (r26571).

I’ve tested your reworked plugin in Sansa e200 simulator. It seems to work fine. But could you please slightly change the button assignement like it is described in  FS#7892  and meanwhile accepted in current viewer as you can see in  FS#2648 . Jumping accidently to begin or end during reading is very anoying.

comment thanks.

updates patch file.

- sync r26136
- merge from r25724, r25844, and r25844.
- when the narrow mode, left key: scroll to the previous page, right key: scroll to the next page.

the rb_text_viewer_2.patch is wrong. sorry.
new patch uploads.


Available keyboard shortcuts


Task Details

Task Editing