Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To
    Björn Stenberg
    Daniel Stenberg
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Frank Gevaerts - 2010-04-26
Last edited by Björn Stenberg - 2010-04-27

FS#11221 - Make upload.pl not mix up files

With the original upload.pl, CGI::tmpFileName() seems to return the same filename again before the move() call in another instance has been completed (or even started). Adding a sleep(1) just before the move() and running many uploads simultaneously results in about 10% wrong files.

The attached patch (suggested by Dave Chapman) fixes the mixup by working with the file handle directly. Adding proper error handling is left as an exercise to the interested perl specialist.

Closed by  Björn Stenberg
2010-04-27 11:00
Reason for closing:  Accepted
Additional comments about closing:  

Committed in r25738.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing