FS#11240 - Allow lower volume for Cowon D2+
Attached to Project:
Rockbox
Opened by Raphaël Jakse (jakse) - Wednesday, 05 May 2010, 11:27 GMT
Last edited by Andree Buschmann (Buschel) - Sunday, 30 May 2010, 18:29 GMT
Opened by Raphaël Jakse (jakse) - Wednesday, 05 May 2010, 11:27 GMT
Last edited by Andree Buschmann (Buschel) - Sunday, 30 May 2010, 18:29 GMT
|
DetailsI just installed Rockbox r25810-100504 on my Cowon D2+ player yesterday. It works quite well.
However, I find the lowest volume, which is -57 dB, too high. If I try -58 dB, the sound is turned off. I usually listen to music at volume 2/3 with the original firmware, but the lowest volume in rockbox seems to be like volume 5 of the original firmware, which is too high for me when there isn't any noise . I don't know wether it is a driver issue or not. I don't know what category is best for this issue. |
This task depends upon
Closed by Andree Buschmann (Buschel)
Sunday, 30 May 2010, 18:29 GMT
Reason for closing: Accepted
Additional comments about closing: Submitted with r26413
Sunday, 30 May 2010, 18:29 GMT
Reason for closing: Accepted
Additional comments about closing: Submitted with r26413
If you take a look at
FS#10082you will see that exactly this change was added to another audio codec driver. Are you able and willing to create a patch to attach it here?I'm unfortunately not able to do the change because I have never writen driver code and I still don't know Cowon D2+ sound hardware. I installed rockbox 2 days ago and have not set any rockbox coding environement yet. I'm not familiar witch patches neither.
However, I can learn to do this and see what I can finely do I'll try to understand the patch you linked and make changes to the Cowon driver, but I'm not confident about testing it myself and it could be long before I can actually write any code...
FS#10082can be easily transferred to the WM8985 driver.Good news, I come with two patches fixing the issue. I think it works, I only tried to play a mp3 file with.
First patch corrects the file wm8985.c, and the second corrects wm8985.h, where the constant VOLUME_MIN is defined. The first patch is likely to depends on the second, and vice versa.
My modifications are strongly inspired of the
FS#10082patch.I think It needs some testing / checking : I did it with lots of intuitions, and this is the first time I :
- patch something
- look at a driver code.
Hope that it will help somebody one day ;)
I would like to have another tester to verify the functionality before I submit your changes.
Attached patch also corrects the manual.
I had time to test more : It works with Ogg and Flac too. I think 90 dB turn the sound off as expected as I can hear a little noise when switching from 89 dB to 90 dB.
I played Rockblock while listening to music, too.
So yes, another tester would by great.
I had a mp3 player with whitch I could listen mp3s with the volume 1 but not wma !
Strange,isn't it ?