Rockbox

A correction to the cutoff and center setting code. Use this instead.

   gigabeat-s-eq-and-3d.v2.diff (29.3 KiB)

Hey, hey. No comments? I was thinking of submenus (obvious, really). All the settings right in the sound menu makes it pretty busy. No input = I’ll think it through and impose my will and let it work itself out. :D

Sound Menu
—-Tone Controls
——–Low Shelf
——–Low Shelf Cutoff
——–Peak 1
——–Peak 1 Center
——–Peak 2
——–Peak 2 Center
——–Peak 3
——–Peak 3 Center
——–High Shelf
——–High Shelf Cutoff
—-3-D Enhancement

Edit: Spaces don’t indent

Edit

Basically the final revision outside of any tweaks that come to mind. The language should minimize chances of confusion between the SW EQ and the hardware controls. If anyone has major objections (I know you’re getting the FS mailings…yes YOU!), they have until tomorrow afternoon (EDT) to scream bloody murder. For that reason, once in SVN, there should be no excuse to admonish the scheme here. It sets up a framework for other sorts of cominations of HW EQ tone control settings and band numbers.

We have:
—-Tone Controls
——–Band 1 Gain
——–Band 1 Frequency
——–Band 2 Gain
——–Band 2 Frequency
——–Band 2 Width
——–Band 3 Gain
——–Band 3 Frequency
——–Band 3 Width
——–Band 4 Gain
——–Band 4 Frequency
——–Band 4 Width
——–Band 5 Gain
——–Band 5 Frequency
—-3-D Enhancement

Gains are highlighted with a different icon, the same used for Bass/Treble currently since in my estimation those settings are more likely to be sought out for changing than the others. Who knows, perhaps gains could be grouped together. I want to minimize menu depth. Perhaps it could have an “advanced” submenu containing all features, otherwise just gains + “Advanced Settings” under “Tone Controls”. That’s easy to rearrage without compatibility concerns.

   gigabeat-s-eq-and-3d.v3.diff (64.9 KiB)

This one presents gains only to the “Tone Controls” submenu along with “Advanced Tone Control Settings” as the last item, which shows settings for *all* parameters, per above diagram. It’s my personal favorite since it keeps things simple and quickly accessible unless you want to get into nitty-gritty.

   gigabeat-s-eq-and-3d.v4.diff (65.6 KiB)

The only thing which comes to my mind is that this menu should state explicit that it is HARDWARE supported not SW supported.

I don’t think there’s a particularly nice way to explain, in the menus themselves, that this set of settings is implemented in hardware and thus more efficient but less flexible. The manual should, of course, say this :)

For the iPod Video, I believe, there was an implementation that was labeled, more-or-less, “Hardware Equalizer”. Well, there’s deprecated strings left over from that reverted attempt.

With the basic Bass and Treble controls, obviously there’s no explanation of their hardware or software nature, which depends on the whether the target has them in hardware. I think I’ll avoid doing that unless it becomes the norm for Rockbox, which never explains it in the menus for other players that have their own hardware effects (like MAS codec Archos players).