FS#11246 - as3525: Stop clock when SDRAM is idle

Attached to Project: Rockbox
Opened by Rafaël Carré (funman) - Thursday, 06 May 2010, 15:32 GMT
Last edited by Rafaël Carré (funman) - Saturday, 08 May 2010, 13:59 GMT
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Operating System Another
Severity Very Low
Priority High
Reported Version Rbutil SVN
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


With attached patch I have 40 minutes more battery life on Clipv1.

I'll test again on Fuzev1 and Clip+ to confirm.

SDRAM setup is done by the bootloader in sdram_init(), so I moved this code into system_init() so there is no need to update the bootloaders to benefit from this : are you OK with that ?

More testing and on other models would be fine too.
This task depends upon

Closed by  Rafaël Carré (funman)
Saturday, 08 May 2010, 13:59 GMT
Reason for closing:  Accepted
Additional comments about closing:  r25900
Comment by Rafaël Carré (funman) - Thursday, 06 May 2010, 15:32 GMT Comment by Bertrik Sikken (bertrik) - Thursday, 06 May 2010, 16:17 GMT
Nice! I l like how this is basically an automatic setting, without having to add explicit enable/disable code.
I can test tonight on the c200v2 and my own clip v1.
Comment by Rafaël Carré (funman) - Friday, 07 May 2010, 08:00 GMT
Seems to give a bit more battery life on Clipv1 / Fuzev2:

Move the setting to the bootloader for AS3525v2 since we will need new bootloaders.

Keep it in rockbox.sansa for AS3525v1 so we can keep using the existing, well-tested bootloader.
Comment by Michael Chicoine (mc2739) - Friday, 07 May 2010, 19:30 GMT
I tested the first patch on my e260v2 with r25836 and got the following results:

without  FS#11246  - 14h 17min (results file on SansaRuntime wiki page)
with  FS#11246  - 16h 26min (results attached)

I will now recharge and test with the second patch.
Comment by Rafaël Carré (funman) - Saturday, 08 May 2010, 13:55 GMT
+1h10 on fuzev2
+30min on clipv1
+2h on e200v2
+1h on clipv2 when boosted (else it crashed too early)