• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Blue_Dude - 2010-05-06
Last edited by Blue_Dude - 2010-05-08

FS#11247 - Hotkey menu items have distinctive icon

Hotkeyable menu items now have a distinctive icon. Color versions are red diamonds, 16 bit gray are darker gray. 1 and 2 color depth bitmaps are unchanged at present.

Closed by  Blue_Dude
2010-05-08 02:20
Reason for closing:  Rejected
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Superseded by later functionality

Added a white dot to the default bitmaps. I don’t know if that’s enough to distinguish them, but it doesn’t hurt anything. The tango_small bitmaps are better defined.

Here are all the bitmaps.

Nicer outline on tango bitmap.

New bitmaps didn’t work so well. Here’s an alternative idea. Also includes a menu setting to enable new icons. Disabled by default.

This has been fairly extensively discussed in IRC today, but just to restate my personal views here :)

I don’t see why hotkeys need specific icons. I would imagine that seeing a random different icons for some items is likely to confuse, not say “this item is hotkeyable”. Also, this doesn’t exist for other similar settable items, such as quickscreen items. Adding a menu item seems overkill to me, surely if anything this is a theme setting, to be set in icon files?

What about just changing the whole hotkey setting mechanism to a list, so you have two settings “WPS hotkey” and 2Menu hotkey” or something, within which you have a list of possibilities and then you just select the one you want? As I understand it there aren’t so many hotkeyable items that the list would be too unwieldy.

fml2 commented on 2010-05-07 21:38

I also think that there is no need in special hotkey icon which *replaces* the original icons. Maybe the hotkey sign should appear as an overlay icon (like in Windows’ Explorer) but we don’t have this possibility in Rockbox. I’d rather leave the icons as they are (i.e. no special icon for hotkeyable items) and show a “Not assignable to the hotkey” splash if the user presses the hotkey on a non-assignable item. Another argument is that hotkey is assigned only once or very rearily. So doesn’t have to look good. Context menu, on the other hand, is use quite often, and hence should look good. And one aspect of “good” for me is that the eye is not disturbed by different icons.

A special setting for the hotkey would also be very good but I don’t have a strong preference here. One huge advantage would be simple voicing and overall being in line with the Rockbox UI.


Available keyboard shortcuts


Task Details

Task Editing