Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Gerbil - 2010-05-11
Last edited by nls - 2010-08-18

FS#11260 - lets keybox import its database from an external text file

This patch is an improvement to the keybox plugin. It lets you import new data from the file “keybox.txt”. The file must reside in the same directory as the “keybox.dat” file. For each new entry, three consecutive lines with Title, User and Password information is read from the file and imported into the database.

This patch avoids the need to use the internal text editor to fill the encrypted data base.

Closed by  nls
2010-08-18 09:42
Reason for closing:  Rejected
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

I'm sorry but this is a too great security risk and even reisk lulling users into false security.

Gerbil commented on 2010-05-11 23:19

It seems that the attachment of the file has not worked

   keybox.diff (4.9 KiB)
Gerbil commented on 2010-05-12 13:54

The new diff file contains the above attached patch and additionally an update for the manual in keybox.tex.

Tested in the Sansa e200 player in the simulator.

   keybox.diff (6.5 KiB)
Gerbil commented on 2010-05-13 11:08

Reworked version of patch with:

* more consistent splash time settings
* asks the user if he wants to delete the unencrypted file and delete it if YES
* manual: including hint, that the deleted file could be reconstructed from raw data on disk

Furthermore I have found a bug in keybox.c. If data is resetted in function “reset” 

rb->gui_synclist_set_nb_items(&kb_list, 0);

must be called additionally to reset the number of items in kb_list too.

   keybox.diff (7.2 KiB)
Gerbil commented on 2010-05-14 11:06

excluded the reset bug patch from above patch (rb→gui_synclist_set_nb_items(&kb_list, 0);). For that patch (11272) has been applied meanwhile into Rockbox I’ve deleted it from this ( FS#11260 ) one.

   keybox.diff (7 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing