Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by bieber - 2010-05-13
Last edited by jdgordon - 2010-08-05

FS#11265 - Beginning of the theme editor parser

Laid some of the groundwork for a generic WPS parser for JdGordon’s skinenginebreak branch

   patch (7.7 KiB)
Closed by  jdgordon
2010-08-05 13:06
Reason for closing:  Out of Date
bieber commented on 2010-05-13 03:31

Updated version with tag table

   patch (13.6 KiB)
bieber commented on 2010-05-15 08:26

Working on parser

   patch (24.7 KiB)
bieber commented on 2010-05-18 07:51

Working on parse_tag

   patch (27.9 KiB)
jdgordon commented on 2010-05-20 09:21

the malloc line in skin_alloc_string(int length) looks like it alloca double the needed bytes?

other than that, I havnt looked at it enough to comment…

bieber commented on 2010-05-24 20:23

Good catch, I had the + 1 (to accomodate the \0 at the end of the string) in the wrong place. Here’s a new patch (hopefully I’ll have SVN access soon) that SHOULD parse any WPS document in your new format successfully, as long as the tags have been added to the tag table. I assumed that we’d use a conditional of the form

%?xx(option1,option2,option3)

since none was specified in your wiki document, just let me know if you’d rather some other format.

   patch (40.9 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing