• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by funman - 2010-05-24
Last edited by funman - 2010-05-27

FS#11312 - as3525v2: relax sd_wait_for_state timeout and retry commands on error

- Higher timeout set to 5 seconds when waiting for the card to be back at transmission state.

I didn’t find a precise timeout in linux source code but this one should be enough.

- yield() while DATA_BUSY bit is set (the linux driver just busy loops)

- retry sending commands up to 6 times before failing

The linux code has a
#define SD_CMD_RETRIES (6) /*!< command retries */

in sd_config.h header

Didn’t run test_disk yet

Closed by  funman
2010-05-27 20:29
Reason for closing:  Accepted

sync to r26251

Similar patch posted on  FS#11267  for v1

performance is a tiny bit slower on fuzev1 but not significantly (some tests were faster with the patch)

same performance difference for clip+


Available keyboard shortcuts


Task Details

Task Editing