Rockbox

Tasklist

FS#11312 - as3525v2: relax sd_wait_for_state timeout and retry commands on error

Attached to Project: Rockbox
Opened by Rafaël Carré (funman) - Monday, 24 May 2010, 14:56 GMT
Last edited by Rafaël Carré (funman) - Thursday, 27 May 2010, 20:29 GMT
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Operating System Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

- Higher timeout set to 5 seconds when waiting for the card to be back at transmission state.

I didn't find a precise timeout in linux source code but this one should be enough.

- yield() while DATA_BUSY bit is set (the linux driver just busy loops)

- retry sending commands up to 6 times before failing

The linux code has a
#define SD_CMD_RETRIES (6) /*!< command retries */

in sd_config.h header

Didn't run test_disk yet
   as3525v2-sd.diff (4.9 KiB)
This task depends upon

Closed by  Rafaël Carré (funman)
Thursday, 27 May 2010, 20:29 GMT
Reason for closing:  Accepted
Comment by Rafaël Carré (funman) - Monday, 24 May 2010, 15:09 GMT
sync to r26251
   as3525v2-sd.diff (4.9 KiB)
Comment by Rafaël Carré (funman) - Monday, 24 May 2010, 15:29 GMT
Similar patch posted on  FS#11267  for v1
Comment by Rafaël Carré (funman) - Monday, 24 May 2010, 15:41 GMT
performance is a tiny bit slower on fuzev1 but not significantly (some tests were faster with the patch)
Comment by Rafaël Carré (funman) - Monday, 24 May 2010, 16:38 GMT
same performance difference for clip+

Loading...