Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Playlists
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by ryran - 2010-06-01
Last edited by fml2 - 2010-12-17

FS#11344 - INSERT via HOTKEY returns to WPS (inconsistent!)

Inconsistency:
HOTKEY_INSERT, HOTKEY_INSERT_SHUFFLED return you to WPS;
straight PLAYLIST_INSERT or PLAYLIST_INSERT_SHUFFLED keep you in tree

Reproduce:
on a track in filebrowser: hold_select > playlist > insert
track is added to your current playlist without taking you to WPS

set hotkey to insert
on a track in filebrowser: hotkey
track is added to your current playlist, but you’re taken back to WPS

In attached patch, you can see how I got around this issue. I’m no expert though, and I wouldn’t be surprised if this isn’t the best way to go about it. Also odd that HK_INSERT & HK_INS_SHUFFLED have different ONPLAY … what’s the term here.. “returns”? I dunno. I’m just figuring things out as I go. :)

I’m on r26444.

Closed by  fml2
2010-12-17 09:59
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed as r28847. Thanks!

ryran commented on 2010-06-01 10:14

aww BOO.

   hotkeyfix.patch (0.6 KiB)
funman commented on 2010-06-25 23:05

Can you come on irc and ping Blue_Dude about it ?

dreamlayers commented on 2010-07-28 00:03

Resynched to r27589.

I feel this is a desirable patch, but not really a bug. The functionality still works as-is; I just find going back to the WPS less convenient. For me, the whole point of these hotkeys is making playlist creation easier. Usually when I am creating a playlist I add multiple files from the file browser. If I need to go from the WPS to the file browser every time, that makes the process slower and kind of annoying.

   hotkeyfix-r27589.patch (0.7 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing