Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#11389 : Work to make the theme parser more rockbox friendly

Rockbox

Tasklist

FS#11389 - Work to make the theme parser more rockbox friendly

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Thursday, 10 June 2010, 14:54 GMT
Last edited by Jonathan Gordon (jdgordon) - Thursday, 10 June 2010, 23:36 GMT
Task Type Patches
Category Utils
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This does some housecleaning to make it more friendly to a rockbox build..

in a rockbox build ROCKBOX is defined so use that to determine which memory management to use. Dont bother storing comments in ROCKBOX build.

Change the element->text to void*data to make elemets more usable in a ROCKBOX build
   parser_integration.0.diff (14.6 KiB)
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Thursday, 10 June 2010, 23:36 GMT
Reason for closing:  Accepted
Comment by Jonathan Gordon (jdgordon) - Thursday, 10 June 2010, 15:36 GMT
I've just re-read the conditional code and it looks like parameters and children are NOT used at the same time, could they be merged into a union (and the counter can then be shared) that drops the element size down to 7*4 bytes, if line can be removed also thats another 4 bytes saved.

(Yes I agree these savings are pretty small, but if we can dynamically size the skin buffer then every saved byte is a free byte for the playback buffer :) )

edit: or alternatively, why not put the params for the tag into the CONDITIONAL element instead of children[0]? That is what I assumed has happening anyway and seems to be clearer...

Loading...