- Status Closed
- Percent Complete
- Task Type Patches
- Category Utils
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Release 3.4
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Rockbox
Opened by Jonathan Gordon - 2010-06-10
Last edited by Jonathan Gordon - 2010-06-10
Opened by Jonathan Gordon - 2010-06-10
Last edited by Jonathan Gordon - 2010-06-10
FS#11389 - Work to make the theme parser more rockbox friendly
This does some housecleaning to make it more friendly to a rockbox build..
in a rockbox build ROCKBOX is defined so use that to determine which memory management to use. Dont bother storing comments in ROCKBOX build.
Change the element→text to void*data to make elemets more usable in a ROCKBOX build
parser_integration.0.diff
(14.6 KiB)
I’ve just re-read the conditional code and it looks like parameters and children are NOT used at the same time, could they be merged into a union (and the counter can then be shared) that drops the element size down to 7*4 bytes, if line can be removed also thats another 4 bytes saved.
(Yes I agree these savings are pretty small, but if we can dynamically size the skin buffer then every saved byte is a free byte for the playback buffer :) )
edit: or alternatively, why not put the params for the tag into the CONDITIONAL element instead of children[0]? That is what I assumed has happening anyway and seems to be clearer…