FS#11400 - Text Viewer Problems #2...

Attached to Project: Rockbox
Opened by Hunter Ragnarok (G4Oblivion) - Sunday, 13 June 2010, 21:02 GMT
Last edited by Steve Bavin (pondlife) - Wednesday, 30 June 2010, 06:26 GMT
Task Type Bugs
Category Plugins
Status Closed
Assigned To Yoshihisa Uchida (Uchida)
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


*sigh*...where to begin....

1) When scrolling through pages there are sometimes different colored bars flashing in the right corner. Might be caused by changing foreground and background colors without restart. I've only had this happen once. I have not done any testing on this issue.

2) Trying to scroll up on the first page or down on the last causes weird text shading problems. Hard to explain.

3) Biggest issue: This randomly happens I've no clue why. I think it might be because when you set a bookmark it moves the text. (Unsure)
The last sentence of a page sometimes gets chopped and doesn't show up on the next page. Sometimes the last sentence of a page shows up on the next page too.
I can get the text to show up sometimes if I keep scrolling between the pages, disappear too.

I've no idea how to reproduce these expect #2. #1 might be because of the colors so, I think it can be reproduced. #3 is purely random so far.

New text viewer is nice but, it comes with so many problems...

EDIT: Reported version = daily build, r26834
This task depends upon

Closed by  Steve Bavin (pondlife)
Wednesday, 30 June 2010, 06:26 GMT
Reason for closing:  Fixed
Comment by Hunter Ragnarok (G4Oblivion) - Sunday, 13 June 2010, 21:04 GMT
I'm sorry. I forgot to set the information.
Category: Plugins
Reported version: Daily build: r26834
Comment by Yoshihisa Uchida (Uchida) - Sunday, 20 June 2010, 11:35 GMT
I confirmed Similar problem.
Please wait for a while until correcting it.
Comment by Yoshihisa Uchida (Uchida) - Monday, 21 June 2010, 14:18 GMT
I send patch.
But your problems (some/all?) might still occur. please confirm.

1) get the source r26997 (not latest version!!)
2) copy apps/plugins/text_viewer/* to other folder.
3) get the latest source
4) copy 2) to the latest version's apps/plugins/text_viewer/.
5) apply my patch.
6) build
Comment by Hunter Ragnarok (G4Oblivion) - Monday, 21 June 2010, 16:18 GMT
I've never tried to set up rockbox before. I will have to use the wiki.
I probably won't be able to get back to you for a few days. I'm watching my sister's place right now.
Comment by Hunter Ragnarok (G4Oblivion) - Tuesday, 22 June 2010, 19:25 GMT
r27045 Fixed the text shading and colored bars problems.
Sentence chopping is still there.
I can't seem to get the compiler working, wiki is a bit confusing.
If you could build r26997 with the patch for Nano 2G, post a link, I'll test it.
Comment by Yoshihisa Uchida (Uchida) - Saturday, 26 June 2010, 09:50 GMT
comment and confirmation thanks.

some problems might have changed because the text viewer is modified since r27138. (but it is may not to be improved at all...)

Comment by Hunter Ragnarok (G4Oblivion) - Sunday, 27 June 2010, 16:54 GMT
I'm not getting the sentence chopping anymore. I haven't tested it too much, but so far no problems.
Using r27143
Comment by Hunter Ragnarok (G4Oblivion) - Tuesday, 29 June 2010, 15:17 GMT
Problem #3 seems to be gone. Thank you.
I have one last thing. The color of Page Number is always white (#FFFFFF). I would like it to be the same color as foreground.
Example: I have my foreground color set to a grayish white and my brightness is set to 10. With those settings Page number really sticks out.
It can be distracting. This is more of a request than asking you to fix something.

This FS can be closed. All bugs were fixed.