Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Rbutil
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Rbutil git
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by judas_iscariote - 2010-06-19
Last edited by Dominik Riebeling - 2010-06-22

FS#11420 - [PATCH] Crash during autodetection

If you lauch RockboxUtility without any device plugged in , and click on the autodetect box, it crashes because you are usb_close()’ing a NULL.

libusb couldn’t open USB device /dev/bus/usb/001/001: Permission denied.
libusb requires write access to USB device nodes.
Program received signal SIGSEGV, Segmentation fault.

Closed by  Dominik Riebeling
2010-06-22 20:15
Reason for closing:  Fixed
Additional comments about closing:  

I've redone this change by myself because our policy requires real names for contributors. However, thanks for spotting it and pointing it out.

Dominik Riebeling commented on 2010-06-20 09:38

While the change is correct I can’t see why this should cause a problem – on all systems I’ve tried libusb finds at least the root hubs so the usb_open() call doesn’t fail. As far as I understand the problem is your setup not having the correct permissions and is not related to devices plugged in or not. Fixing this issue would be good in any case.

However, I have two problems accepting this patch:
1. Rockbox has a real name policy. You haven’t provided your real name to Flyspray.
2. You are not following the Rockbox coding style (tabs instead of spaces).

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing