• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category FM Tuner
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.4
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by bertrik - 2010-06-20
Last edited by bertrik - 2010-06-21

FS#11423 - Use udelay in AMS driver for FM radio I2C

Attached patch uses udelay to time I2C transfers for FM radio, instead of using the current crude delay.

This makes timing (mostly) processor speed independent, so less time wasted in busy-loops.
I also simplified the generic i2c driver a bit, replacing the various delay functions with a single one that takes a delay parameter.

I’d like people to test on the following targets (basically the AMS/AMSv2 targets):
* m200v4
* clipv2
* c200v2
* e200v2
* fuze v1
* fuze v2
(I already tested it myself on clip v1, clip+)
Just check if the radio is still detected and if radio tuning and reception still works.

Closed by  bertrik
2010-06-21 21:41
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed as SVN r27035, thanks for testing!

Tested on e200v2 (r26997) with no noticeable issues,

Tested on fuzev1 r27015 no isues, seems to work fine. Checked radio, playback, just tried plugins without really testing and no problems.


Available keyboard shortcuts


Task Details

Task Editing