Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Codecs
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.6
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by saratoga - 2010-07-05
Last edited by saratoga - 2010-07-06

FS#11458 - Fix test_codec on low memory targets

test_codec currently only works when the test file is smaller then the audio buffer. This makes it fail on low memory targets. This patch corrects that.

   test_codecv1.patch (4.3 KiB)
Closed by  saratoga
2010-07-06 00:11
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Accepted in r27303.

funman commented on 2010-07-05 20:51

Clipv1 results: http://pastie.org/1031736

MP3 and aache are broken, it seems that decoding stops at the first rebuffer

saratoga commented on 2010-07-05 21:06

Fixes MP3 for me (have to try AAC-HE yet).

   test_codecv2.patch (4.7 KiB)
saratoga commented on 2010-07-05 21:43

AAC-He problems are due to AAC-He not working on low memory targets, so I think its not a bug in test_codec (or if it is we won’t know until HE is fixed).

funman commented on 2010-07-05 23:19

With v2: http://pastie.org/1031920

Looks ok, please commit we can still fix AAC-HE later

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing