Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Codecs
  • Assigned To No-one
  • Operating System Coldfire-based
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.6
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Buschel - 2010-07-22
Last edited by Buschel - 2010-07-22

FS#11491 - Change to Coldfire part of libmad's synthesis filter

This patch moves the coldfire inline asm from synth_full() to 4 macros. Two of those macros are used twice within synth_full() with slightly modified calling parameters. I do not see a possiblity to re-use of the residual asm (for now).

Benefit of this change is much better readability of the synth_full() function. Furthermore we get the future possibility to go back to a single full_synth() function and only using CPU-dependent macros.

Remark to readability: For debugging purpose I have left the former inline asm commented in synth_full(). When this patch should be committed, I will remove this of course.

As I do not have any coldfire target, I can only compile for such target (it does for h300). I need a test on coldfire target to check, if the output compared to svn is still the same.

Closed by  Buschel
2010-07-22 18:58
Reason for closing:  Accepted
Additional comments about closing:  

Submitted with r27524

Thanks to Nils Wallménius for debugging support with the first v02-patch.

Add "memory" to clobber list.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing