FS#11493 - bookmark on stop doesn't work on sleep timeout

Attached to Project: Rockbox
Opened by Tim Middleton (timtoo) - Thursday, 22 July 2010, 15:01 GMT
Last edited by Thomas Jarosch (thomasjfox) - Thursday, 03 March 2011, 00:27 GMT
Task Type Bugs
Category Music playback
Status Closed
Assigned To Thomas Jarosch (thomasjfox)
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


This used to work, I think back in 3.4.

While (settings -> general -> bookmarking) "bookmark on stop" is enabled, when the player is stopped via (system -> time & date) sleep timer, a bookmark is not created before the player powers down.

This task depends upon

Closed by  Thomas Jarosch (thomasjfox)
Thursday, 03 March 2011, 00:27 GMT
Reason for closing:  Fixed
Additional comments about closing:  Thanks for the initial patch!

I verified the code paths and fixed it properly.

For the record:
clean_shutdown() calls audio_stop() after the bookmark creation (as it's supposed to be).
Comment by Marek Salaba (salaba) - Sunday, 22 August 2010, 08:52 GMT
I tested on Sansa Fuse v2 r27850 and If I have set function "bookmark on stop" on "yes" and set "sleep timer", the bookmark don't created.
Comment by Teruaki Kawashima (teru) - Friday, 15 October 2010, 13:42 GMT
this seems to fix the bug.
Comment by Torne Wuff (torne) - Friday, 15 October 2010, 13:49 GMT
That only fixes it for the case where the player isn't plugged in.
Comment by Andy Smith (ufo) - Saturday, 06 November 2010, 12:51 GMT
Can second this, very annoying bug.
Comment by Andy Smith (ufo) - Saturday, 06 November 2010, 12:52 GMT
Almost making me go back to original firmware for Sleep Timer it's so annoying !