FS#11562 - themes not working ok

Attached to Project: Rockbox
Opened by federico pelupessy (fip) - Sunday, 22 August 2010, 21:43 GMT
Last edited by Jonathan Gordon (jdgordon) - Thursday, 16 September 2010, 13:18 GMT
Task Type Bugs
Category Themes
Status Closed
Assigned To No-one
Operating System iAudio X5
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


on revision 27859, I cannot set any complex theme (e.g. rockbox_default works, cabbie not)
it freezes upon selecting...

it was ok on the revision of a week ago or so

(x5l, normal build)
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Thursday, 16 September 2010, 13:18 GMT
Reason for closing:  Fixed
Additional comments about closing:  should be fixed
Comment by federico pelupessy (fip) - Monday, 23 August 2010, 20:12 GMT
additional: a simulator build seg faults when changing to rockbox_default and back to Cabbie...
Comment by Stephen Carroll (StephenCarroll) - Tuesday, 24 August 2010, 18:15 GMT
I noticed this last week when I updated and last night i bi-sected builds and came to the conclusion r27828 is the reason for this.
Comment by Marianne Arnold (pixelma) - Thursday, 26 August 2010, 23:08 GMT
When running a simulator in gdb and changing themes a few times I get the following after a few tries, no matter which themes and if they have an SBS or not - all I tried were built-in ones:

Program received signal SIGSEGV, Segmentation fault.
0x0000000000436d7e in set_title_worker (title=0x0, icon=Icon_NOICON,
data=0x781870, root=0x935d40)
at /home/marianne/rockbox/apps/gui/statusbar-skinned.c:95
95 retval |= set_title_worker(title, icon, data, element->children[i]);

I saw these in an X5 sim, M5 sim, H300 sim but not in an M3 sim though. It took a different amount of theme switches (most on H300) but it hit in the end.

Stephen: are you sure 27828 is the culprit, not 27829?
I'm just wondering a bit as the first has something to do with FMSs and the second with SBSs which is a bit more general, whereas r27829 was even a change to the file that caused the crash. (My M5 sim was also not configured for the FM mod, so shouldn't have any radio skin related things at all).
Comment by Stephen Carroll (StephenCarroll) - Tuesday, 31 August 2010, 21:28 GMT
Just tested my files again and it is indeed 27829. Sorry for the mistake.
Also I think it does have something to do with remotes because testing the h300 sim and the fuze v2 sim I have a theme file which crashes the h300 sim and doesn't crash the fuze v2 sim.
As in your other comment I believe is also linked to this bug.

Here's a link to 27829

So last known working revision is 27828.
Tested on two x5's.
Comment by Jonathan Gordon (jdgordon) - Wednesday, 08 September 2010, 00:16 GMT
 FS#11614  includes a fix for this, and coincidentaly could do with some testing