Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by MItaly - 2010-08-26
Last edited by jdgordon - 2010-09-03

FS#11573 - Cabbiev3 doesn't show progress bar and album art in current build

As specified in the summary, the (IMO) great theme Cabbiev3 presents several problems with the current build, because, as it is, it doesn’t use separate viewports for the progress bar and the album art.

Here’s a fix for the 220×176 color targets version. I also removed the empty line between the album name and the next track label to make the theme more big-fonts friendly.
I’m not sure of having done everything correctly (it’s the first time I edit themes), but it seems to work fine in the sim.

   cabbiev3.patch (0.5 KiB)
Closed by  jdgordon
2010-09-03 00:27
Reason for closing:  Invalid
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

theme fixes (except for the ones shipped in rockbox.zip) dont belong here

MItaly commented on 2010-08-26 19:33

Forgot to say, the patch has to be applied to cabbiev3.wps.

St. commented on 2010-08-28 03:05

My suggestion would be to leave a note with the original author of the theme.
Authors *should* have been more than aware of the syntax/parser change(s) and all that went with it.

[St.]

MItaly commented on 2010-08-28 14:00

Yes, you’re right, I’ll send him an e-mail.

MItaly commented on 2010-08-28 18:58

Fixed also the localization issue of the “Next:” label. Here I provide the diff (a working one, I hope, now :S ) and the complete file, which, for such a small file, may be more convenient.

   cabbiev3.wps (2 KiB)
   cabbiev3.wps.diff (1.6 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing