Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System Sansa e200
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by ewillner - 2010-08-31
Last edited by jdgordon - 2010-09-02

FS#11588 - Conditionals with Timings

This issue can be demonstrated with the following wps code:

Line 1:
%?ic<%s%al%t(6)Composer:|%t(0)>;%?iA<%s%al%t(6)Alb Artist:|%t(0)>;%?ia<%s%al%t(6)Trk Artist:|%t(0)>
Line 2:
%?ic<%s%al%t(6)%ic|%t(0)>;%?iA<%s%al%t(6)%iA|%t(0)>;%?ia<%s%al%t(6)%ia|%t(0)>

There are 3 alternating displays (the info for each is divided into 2 lines):

  • Composer
  • Track Artist
  • Album Artist

On top of that is a conditional. The conditional says that if the tag value is blank, skip (or display for time=zero) that display.

For example if the composer tag = “abc”, and there are no Track Artist or Album Artist tags, the display will be:

Composer
ABC

and there would be no alternating text (because of the conditional.

What is happening for me is that the blanks are displaying alternatively. It is as if the %t(0) tag is being displayed for a short time instead of no time at all.

In order to help diagnosis of the issue, I added ;%t(0) - 25 times at the end of one of the two lines. The two lines have always been in sync (same conditions, same timings, just different text being displayed.

The two lines were out of sync - which means to me that the ;%t(0) did add some time.

See also http://forums.rockbox.org/index.php?topic=25545.0 in the forum for a discussion of this issue.

Closed by  jdgordon
2010-09-02 11:44
Reason for closing:  Fixed
Additional comments about closing:  

in r27983

This seems to work, needs testing and cleaning up though.

Which e200 do you have? I’ll do a build for oyu if you cant build your own

this one is a bit cleaner

My e200 is a V1. I can’t do a patch build, but if you send me one, I will test it.

Thanks

I didn’t mean send - if I can download a build from somewhere, I will test it. (A simulator build will be even easier:)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing