• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.6
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by pixelma - 2010-08-31
Last edited by jdgordon - 2010-10-13

FS#11593 - %Vf/%Vb (viewport colours) not working in conditionals

The colour parameters were made independent of the viewport definitions not long ago which was supposed to give the opportunity to e.g. change the line colour within the viewport - and I asked in IRC - should also have given the opportunity to put the colours in conditionals (e.g. you could make the volume display turn red if volume is set to above 0dB etc.).

I tried this because it would greatly simplify my WPS which uses these “indicator” colours but gets the effect with the help of conditional viewports for now.

For a first try I only wrote the following test.wps which should display the word “Test” in magenta if the hold switch is off and in cyan if it is on:


(also tried putting the %?mh conditional on its own line)

When entering the WPS (hold off), the magenta “Test” is displayed correcty, if I switch hold the text disappears and won’t come back anymore however often I switch hold on or off. This was tested in an X5 sim but also with grey shades in an M5 sim and on target.

Closed by  jdgordon
2010-10-13 09:47
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

in r28266

I tried what was suggested in the first closing message (see History tab here ^ ) adapted to greyshades for my M5 and by using %pc as dynamic tag.

My new test.wps looks as follows: but it didn’t work. The TTT or GGG inside the conditional but behind the %Vf tags didn’t show up at all but I’m not sure if they should. The foreground greyshade didn’t change, it just stayed black (0).


Available keyboard shortcuts


Task Details

Task Editing