FS#11593 - %Vf/%Vb (viewport colours) not working in conditionals

Attached to Project: Rockbox
Opened by Marianne Arnold (pixelma) - Tuesday, 31 August 2010, 18:22 GMT
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 13 October 2010, 09:47 GMT
Task Type Bugs
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


The colour parameters were made independent of the viewport definitions not long ago which was supposed to give the opportunity to e.g. change the line colour within the viewport - and I asked in IRC - should also have given the opportunity to put the colours in conditionals (e.g. you could make the volume display turn red if volume is set to above 0dB etc.).

I tried this because it would greatly simplify my WPS which uses these "indicator" colours but gets the effect with the help of conditional viewports for now.

For a first try I only wrote the following test.wps which should display the word "Test" in magenta if the hold switch is off and in cyan if it is on:


(also tried putting the %?mh conditional on its own line)

When entering the WPS (hold off), the magenta "Test" is displayed correcty, if I switch hold the text disappears and won't come back anymore however often I switch hold on or off. This was tested in an X5 sim but also with grey shades in an M5 sim and on target.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Wednesday, 13 October 2010, 09:47 GMT
Reason for closing:  Fixed
Additional comments about closing:  in r28266
Comment by Marianne Arnold (pixelma) - Saturday, 18 September 2010, 12:02 GMT
I tried what was suggested in the first closing message (see History tab here ^ ) adapted to greyshades for my M5 and by using %pc as dynamic tag.

My new test.wps looks as follows: but it didn't work. The TTT or GGG inside the conditional but behind the %Vf tags didn't show up at all but I'm not sure if they should. The foreground greyshade didn't change, it just stayed black (0).