- Status Closed
- Percent Complete
- Task Type Patches
- Category User Interface
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Release 3.6
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#11606 - ACTION_TREE_STOP stops radio too
Rationale:
To my mind it is more consistent - at the moment, you are in the WPS, you press the menu key, then the ACTION_TREE_STOP key, and your music stops. You are in the radio, you press the same, and nothing happens.
Implementation:
Obviously, this is trivial in extremis, but I’m no coder… I’ve included radio.h, and added a call to radio_stop() in list_stop_handler(), in misc.c. Both changes are behind ifdef CONFIG_TUNERs. This is guesswork, and might be horribly wrong, but it seems to work on a Sansa Clip+. I tried turning off CONFIG_TUNER to test it, but that results in all kinds of oddness, and I don’t think it’s because of this patch.
Built against 27999.
Closed by nls
2010-10-17 08:48
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2010-10-17 08:48
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
comiitted, thanks
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Also, thanks to JdGordon for the advice.