Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.6
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Michael Gentry - 2010-09-06
Last edited by Nils Wallménius - 2010-10-17

FS#11606 - ACTION_TREE_STOP stops radio too

Rationale:
To my mind it is more consistent - at the moment, you are in the WPS, you press the menu key, then the ACTION_TREE_STOP key, and your music stops. You are in the radio, you press the same, and nothing happens.

Implementation:
Obviously, this is trivial in extremis, but I’m no coder… I’ve included radio.h, and added a call to radio_stop() in list_stop_handler(), in misc.c. Both changes are behind ifdef CONFIG_TUNERs. This is guesswork, and might be horribly wrong, but it seems to work on a Sansa Clip+. I tried turning off CONFIG_TUNER to test it, but that results in all kinds of oddness, and I don’t think it’s because of this patch.

Built against 27999.

Closed by  Nils Wallménius
2010-10-17 08:48
Reason for closing:  Accepted
Additional comments about closing:  

comiitted, thanks

Michael Gentry commented on 2010-09-06 14:05

Also, thanks to JdGordon for the advice.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing