• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category Settings
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.6
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by MarcinBukat - 2010-09-20
Last edited by MarcinBukat - 2010-09-20

FS#11634 - settings_load_config() calls config_save()

I found accidentally that settings_load_config() which is called at startup of the rb calls config_save(). This means that config file is rewiriten on every system startup. This can impact flash wear.

look at apps/settings.c:370

Closed by  MarcinBukat
2010-09-20 13:42
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

commited as r28120

Looks like it was added in r2479 for equalizers, and kept in r4772

For me it looks like it was introduced in r12142 and never touched from then.

Right this line was added in r2479 and later there ware code refactorings.

I poked around and for me this call is simply not needed any more. Here is the patch that removes it.


Available keyboard shortcuts


Task Details

Task Editing