Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Settings
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.6
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by MarcinBukat - 2010-09-20
Last edited by MarcinBukat - 2010-09-20

FS#11634 - settings_load_config() calls config_save()

I found accidentally that settings_load_config() which is called at startup of the rb calls config_save(). This means that config file is rewiriten on every system startup. This can impact flash wear.

look at apps/settings.c:370

Closed by  MarcinBukat
2010-09-20 13:42
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

commited as r28120

funman commented on 2010-09-20 07:57

Looks like it was added in r2479 for equalizers, and kept in r4772

MarcinBukat commented on 2010-09-20 08:49

http://svn.rockbox.org/viewvc.cgi/trunk/apps/settings.c?view=diff&r1=12141&r2=12142

For me it looks like it was introduced in r12142 and never touched from then.

MarcinBukat commented on 2010-09-20 09:12

Right this line was added in r2479 and later there ware code refactorings.

MarcinBukat commented on 2010-09-20 12:15

I poked around and for me this call is simply not needed any more. Here is the patch that removes it.

   settings_load_config.patch (0.3 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing