- Status Closed
- Percent Complete
- Task Type Bugs
- Category Playlists
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Release 3.6
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#11678 - Make the playlist catalog use the normal file browser instead of a custom browser with crappy limits
inspisred by the fact that the playlist cataloge has a file limit http://forums.rockbox.org/index.php?topic=25972.0
This patch makes the playlist catalog use the normal file browser code to select and display a m3u[8].
The changes to tree.c are a bit hacky.. Ideally the context should be changed, but i think this is a good start. Also dirbrowse() really could use better return value handling.
playlist_catalog.diff
(12.3 KiB)
Closed by teru
2010-12-15 13:13
Reason for closing: Out of Date
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2010-12-15 13:13
Reason for closing: Out of Date
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Superseded by FS#11777 .
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
i tried this, and it doesn't work at all in Main menu → Playlists → View Catalog.
in Main menu → Playlists → View Catalog:
- it also displayes bookmarks.
- if you simply press left, it just go to above directory instead of returning to Playlist menu.
- it doesn't say "No Playlists" when the playlist directory is empty.
- select playlist → contexet menu → add to playlist doesn't work.
- most_recent_playlist is no longer used.
- undefined reference to printf :).
i fixed these except most_recent_playlist thing.
Thanks. Thinking about it more this morning, this patch is really nothing more than proof-of-concept. It really needs a bit of a dirbrowse()/tree.c rework to do properly.
the most_recent_playlist thing is an interesting one. The quick fix is getting a it from the browsers sort function and only use it when in this catalog browser. Or the proper way makes dirbrowse() *far* more complicated by passing in a sort callback, an action handler callback, and some way to get a better return value than the GO_TO_* values (we really want to know if the user canceled the screen, or exited because they loaded a file)
Or alternativly, we could ignore the sorting problem and just add another playlist catalog menu item, so along side "add to new playlist" and "add to playlist" we can have "add to: <last playlist name>" which would solve that issue and be the same amount of key presses
as for the most_recent_playlist thing, another option is selecting the last playlist by default when enter the playlist catalog similer to Fonts,WPS, etc. setting menus.
thats a much better idea than a new menu option :p
I'd almost say commit it but I tihnk it needs to wait till the release happens :/
i made some improvements to rockbox_browse()
FS#11777. how do you think?