Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by flan_suse - 2010-10-17
Last edited by RMenes379 - 2010-10-31

FS#11682 - disktidy plugin does not clean custom files.

Daily build: r28294-101016

This disktidy plugin will not delete files that were added under “Other” when added as a custom entry.

I edited disktidy.config and added a custom string that I wish to be cleaned out. Here is an example:

# Disktidy
When adding a new file, make sure its NOT
ALL >:
NONE >:
Windows >: no

  desktop.ini: no
  Thumbs.db: no
  Recycled/: no
  $RECYCLE.BIN/: no
  System Volume Information/: no

< Mac OSX >: no

  .Trashes/: no
  .DS_Store: no
  ._*: no

< Linux/BSD >: no

  .Trash-*/: no
  .dolphinview: no
  .d3lphinview: no

< Other >: no

  • .bmark: no

As you can see, I want the plugin to clean out all of my bookmarks. In Rockbox, I enable the bottom entry. When I launch the cleaner, it says “0 files cleaned”, and all my .bmark files remain untouched.

Closed by  RMenes379
2010-10-31 13:06
Reason for closing:  Accepted
Additional comments about closing:  

Committed as r28414.

I might be wrong but iirc, you can only put a * at the end of the file. For
.Trash-*/

Perhaps someone who knows the plugin better than me can have a look. I guess it wouldn’t be too hard to implement support for * at the begining.

teru commented on 2010-10-17 11:28

here is a patch to allow a * at the end or
will

these don’t
*xyz*

teru commented on 2010-10-18 12:10

here is another patch, which allos up to one * in filestring. “xyz*”, “*xyz”, and “x*z” will work.

Maybe a disclaimer should be included with the default disktidy.config file, to warn users that custom strings can be dangerous and could lead to data loss? I just realized the risk involved from a simple typo in the config file.

Maybe something like:

# Disktidy
When adding a new file, make sure its NOT
Use extreme caution with custom entries, as you could accidentally delete important files

teru commented on 2010-10-28 10:57

it sounds good idea. added to
updated the manual entry including the warning.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing