Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Confuseling - 2010-11-01
Last edited by speachy - 2019-01-02

FS#11711 - WPS Hotkey: Create bookmark

This patch simply adds a ‘Create bookmark’ option to the WPS hotkey, calling bookmark_create_menu

Built against r28432.

Thanks to Torne for advice, and Seani whose patch (11541) helped me figure out how to do this.

Closed by  speachy
2019-01-02 16:37
Reason for closing:  Accepted
Additional comments about closing:  

An updated version of this patch finally landed. Only took eight years. :P

At first glance this looks like it would work, but I would recommend not inserting HOTKEY_BOOKMARK into the middle of the enum. Put it at the end instead. This ensures that you don't break backward compatibility with user settings.

That makes sense, thanks. For the sake of consistency, I've moved it all to the end.

This works for me on a fuze v2. I was supprized to find this key function ( implemented as a long press on the wps key) lost in the move from 3.6 to 3.7.
Thank you!!!

Thanks for testing - I'm glad it works.

If you have any other bright ideas about things that would make a good extra hotkey option, I can't offer any guarantees I can work out how to do them (create bookmark, I suspect, is unusually simple), but I'll have a look…

http://forums.rockbox.org/index.php?topic=25682.0

The thing I'm seeing now as I have used your patch for two days is I am getting a bookmark file one level above the directory of my audiobook/lecture directory for each individual audiobook/lecture I listen to. It does contain the multiple bookmarks I have made. Which is good. But under 3.6, I was able to forgo these extraneous files by setting my bookmarks to recent folder creation and unique bookmarks only.
I would like this multi-bookmark file made when I set the bookmarking to non-unique under bookmarking settings and it should be made in the directory of the audiobook/lecture I'm listening to.
Good work!!!

It looks like a great feature, which will be integrated?
Salaba

Please integrate this to release 3.8.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing