FS#11711 - WPS Hotkey: Create bookmark

Attached to Project: Rockbox
Opened by Michael Gentry (Confuseling) - Monday, 01 November 2010, 18:47 GMT
Last edited by Solomon Peachy (pizza) - Wednesday, 02 January 2019, 16:37 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


This patch simply adds a 'Create bookmark' option to the WPS hotkey, calling bookmark_create_menu

Built against r28432.

Thanks to Torne for advice, and Seani whose patch (11541) helped me figure out how to do this.
This task depends upon

Closed by  Solomon Peachy (pizza)
Wednesday, 02 January 2019, 16:37 GMT
Reason for closing:  Accepted
Additional comments about closing:  An updated version of this patch finally landed. Only took eight years. :P
Comment by Jeffrey Goode (Blue_Dude) - Monday, 08 November 2010, 16:26 GMT
At first glance this looks like it would work, but I would recommend not inserting HOTKEY_BOOKMARK into the middle of the enum. Put it at the end instead. This ensures that you don't break backward compatibility with user settings.
Comment by Michael Gentry (Confuseling) - Tuesday, 09 November 2010, 12:57 GMT
That makes sense, thanks. For the sake of consistency, I've moved it all to the end.

Comment by Bill Weber (tufur1) - Wednesday, 10 November 2010, 17:22 GMT
This works for me on a fuze v2. I was supprized to find this key function ( implemented as a long press on the wps key) lost in the move from 3.6 to 3.7.
Thank you!!!
Comment by Michael Gentry (Confuseling) - Friday, 12 November 2010, 13:08 GMT
Thanks for testing - I'm glad it works.

If you have any other bright ideas about things that would make a good extra hotkey option, I can't offer any guarantees I can work out how to do them (create bookmark, I suspect, is unusually simple), but I'll have a look...
Comment by Bill Weber (tufur1) - Saturday, 13 November 2010, 06:20 GMT
The thing I'm seeing now as I have used your patch for two days is I am getting a bookmark file one level above the directory of my audiobook/lecture directory for each individual audiobook/lecture I listen to. It does contain the multiple bookmarks I have made. Which is good. But under 3.6, I was able to forgo these extraneous files by setting my bookmarks to recent folder creation and unique bookmarks only.
I would like this multi-bookmark file made when I set the bookmarking to non-unique under bookmarking settings and it should be made in the directory of the audiobook/lecture I'm listening to.
Good work!!!
Comment by Marek Salaba (salaba) - Saturday, 15 January 2011, 13:08 GMT
It looks like a great feature, which will be integrated?
Comment by Marek Salaba (salaba) - Sunday, 06 February 2011, 19:17 GMT
Please integrate this to release 3.8.