• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.6
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Bertrik Sikken - 2010-11-06
Last edited by Bertrik Sikken - 2010-11-09

FS#11729 - AS3525/AS3525v2: remove unneeded I2SIN clock configuration

Currently the i2s (audio transport bus) has two clocks enabled, one for playback (i2sout) and one for recording (i2sin). It looks like we really need to configure only one of these, the i2sout clock. Recording is already configured to use the same clock (for details, see bit 8-9 in I2SIN_CONTROL).

This patch removes the unnecessary clock setup. This stops the i2sin clock from being generated, possibly even saving a little power. Also this simplifies the source code a bit.

To test this patch, try to alternate between recording and playback at various rates and see if they still work as expected.

Closed by  Bertrik Sikken
2010-11-09 21:54
Reason for closing:  Accepted
Additional comments about closing:  

Committed in SVN r28541


Available keyboard shortcuts


Task Details

Task Editing