Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Rbutil
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Rbutil git
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by RMenes379 - 2010-11-07
Last edited by RMenes379 - 2011-01-06

FS#11732 - Rockbox Utility: Add support for Philips GoGear HDD16x0 and HDD63x0 series

This patch adds support to install Rockbox on the Philips GoGear HDD16x0 and HDD63x0 series. As the bootloader install method is similar to other PP-based targets (MI4-based), simply updating rbutil.ini should be sufficient.

I may commit this soon if it tests clean.

Closed by  RMenes379
2011-01-06 18:29
Reason for closing:  Accepted
Additional comments about closing:  

Committed.

I can't try the installation itself, but two comments:

- the section [0471014b] is unnecessary. The sections named after the USB IDs are only used for detecting incompatible players (or if a player is in an incompatible mode that can be detected via a different USB ID, like the Nano 2g in DFU mode)
- you're writing the USB IDs as hex code with upper case letters, while all other entries use lower case letters. ini files are case sensitive, and I'm somewhat sure the code uses lower case representations (this doesn't make a difference for the usbid value since that is converted into a number, but it does make a difference for the USB ID named sections). IMO it would be best to simply stick to lower case representations – IMO making the code case insensitive is not worth the additional code for this.

Thanks for the feedback. I'll make those fixes and try it again.

New version with the fixes made.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing